<

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files Errors
40 457

Files

Files Errors
org/apache/maven/app/Expand.java 20
org/apache/maven/app/JellyUtils.java 1
org/apache/maven/app/App.java 16
org/apache/maven/app/Maven.java 58
org/apache/maven/app/ProjectVerifier.java 6
org/apache/maven/app/GrantPropsHandler.java 1
org/apache/maven/app/PluginManager.java 36
org/apache/maven/app/MavenJellyContext.java 8
org/apache/maven/MavenUtils.java 56
org/apache/maven/java/BaseVisitor.java 73
org/apache/maven/java/DepVisitor.java 8
org/apache/maven/java/ImportStatementVisitor.java 3
org/apache/maven/java/JavaClass.java 1
org/apache/maven/java/JavaDocTagTokenizer.java 4
org/apache/maven/java/JavaDocVisitor.java 3
org/apache/maven/java/Method.java 4
org/apache/maven/java/NodeViewVisitor.java 3
org/apache/maven/java/SourceTool.java 1
org/apache/maven/jelly/tags/project/AddPathTag.java 8
org/apache/maven/jelly/tags/project/DirectoryList.java 3
org/apache/maven/jelly/tags/project/SnapshotSignature.java 1
org/apache/maven/jelly/tags/project/MavenTag.java 13
org/apache/maven/MetaPropertiesRule.java 2
org/apache/maven/project/repository/CvsRepository.java 18
org/apache/maven/project/BaseObject.java 6
org/apache/maven/project/Dependency.java 11
org/apache/maven/project/Project.java 21
org/apache/maven/project/Repository.java 9
org/apache/maven/project/UnitTest.java 6
org/apache/maven/project/Workspace.java 12
org/apache/maven/project/Build.java 6
org/apache/maven/project/SourceModification.java 4
org/apache/maven/repository/AbstractArtifact.java 2
org/apache/maven/repository/AbstractRepositoryLayout.java 1
org/apache/maven/repository/Artifact.java 2
org/apache/maven/repository/DefaultJarArtifact.java 8
org/apache/maven/repository/DefaultRepositoryLayout.java 1
org/apache/maven/util/HttpUtils.java 5
org/apache/maven/util/StringInputStream.java 1
org/apache/maven/CreateDependencyClasspath.java 15

org/apache/maven/app/Expand.java

Error Line
Line does not match expected header line of ''. 2
Unused import - java.util.Vector 66
variable 'dest' missing Javadoc. 81
variable 'source' missing Javadoc. 82
variable 'overwrite' missing Javadoc. 83
Unused @throws tag for 'BuildException'. 88
Expected @throws tag for 'Exception'. 91
Expected @param tag for 'fileUtils'. 103
Expected @param tag for 'srcF'. 103
Expected @param tag for 'dir'. 103
line longer than 80 characters 123
Expected @param tag for 'fileUtils'. 143
Expected @param tag for 'srcF'. 143
Expected @param tag for 'dir'. 143
Expected @param tag for 'compressedInputStream'. 144
Expected @param tag for 'entryName'. 145
Expected @param tag for 'entryDate'. 146
Expected @param tag for 'isDirectory'. 146
Expected @throws tag for 'IOException'. 147
Expected @param tag for 'b'. 236

org/apache/maven/app/JellyUtils.java

Error Line
line contains a tab character 93

org/apache/maven/app/App.java

Error Line
Unused import - org.apache.tools.ant.DemuxOutputStream 80
type is missing a Javadoc comment. 86
variable 'maven' missing Javadoc. 91
variable 'commandLine' missing Javadoc. 93
method is missing a Javadoc comment. 104
method is missing a Javadoc comment. 109
method is missing a Javadoc comment. 114
Expected @throws tag for 'Exception'. 131
method is missing a Javadoc comment. 200
method is missing a Javadoc comment. 245
method length is 215 lines (max allowed is 150). 246
line longer than 80 characters 469
line longer than 80 characters 470
method length is 194 lines (max allowed is 150). 491
method is missing a Javadoc comment. 785
method is missing a Javadoc comment. 799

org/apache/maven/app/Maven.java

Error Line
variable 'INSTANCES' missing Javadoc. 137
variable 'isDebug' missing Javadoc. 182
Expected @param tag for 'mavenHome'. 196
'(' is followed by whitespace. 198
')' is preceeded by whitespace. 198
'(' is followed by whitespace. 201
')' is preceeded by whitespace. 201
Expected @throws tag for 'Exception'. 212
Unused Javadoc tag. 280
Expected @param tag for 'project'. 282
'(' is followed by whitespace. 331
')' is preceeded by whitespace. 332
'(' is followed by whitespace. 334
'(' is followed by whitespace. 334
')' is preceeded by whitespace. 335
')' is preceeded by whitespace. 335
',' needs to be followed by whitespace. 367
'(' is followed by whitespace. 404
')' is preceeded by whitespace. 404
'(' is followed by whitespace. 414
')' is preceeded by whitespace. 414
Expected @param tag for 'projectVerifier'. 468
Expected an @return tag. 476
'(' is followed by whitespace. 512
')' is preceeded by whitespace. 512
'(' is followed by whitespace. 523
')' is preceeded by whitespace. 523
Expected an @return tag. 529
Expected @param tag for 'key'. 529
'(' is followed by whitespace. 564
')' is preceeded by whitespace. 564
'(' is followed by whitespace. 567
')' is preceeded by whitespace. 567
'(' is followed by whitespace. 570
')' is preceeded by whitespace. 570
line longer than 80 characters 576
Unused @throws tag for 'DescriptorException'. 598
Expected @throws tag for 'Exception'. 602
line longer than 80 characters 616
',' needs to be followed by whitespace. 657
line longer than 80 characters 684
'(' is followed by whitespace. 709
')' is preceeded by whitespace. 709
Expected @throws tag for 'Exception'. 735
'(' is followed by whitespace. 737
')' is preceeded by whitespace. 737
'(' is followed by whitespace. 740
')' is preceeded by whitespace. 740
'(' is followed by whitespace. 742
')' is preceeded by whitespace. 742
Expected an @return tag. 785
Expected @throws tag for 'Exception'. 786
Expected @throws tag for 'Exception'. 797
'(' is followed by whitespace. 810
')' is preceeded by whitespace. 810
line longer than 80 characters 1007
',' needs to be followed by whitespace. 1020
Expected an @return tag. 1036

org/apache/maven/app/ProjectVerifier.java

Error Line
variable 'log' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'. 104
Unused @param tag for 'the'. 189
Expected @param tag for 'context'. 191
line longer than 80 characters 377
line longer than 80 characters 453
line longer than 80 characters 483

org/apache/maven/app/GrantPropsHandler.java

Error Line
method is missing a Javadoc comment. 130

org/apache/maven/app/PluginManager.java

Error Line
Unused import - java.net.URL 64
Unused import - java.net.URLClassLoader 65
Unused import - java.util.Enumeration 67
Unused import - java.util.HashMap 68
'static' modifier out of order with the JLS suggestions. 108
'static' modifier out of order with the JLS suggestions. 113
'static' modifier out of order with the JLS suggestions. 118
'static' modifier out of order with the JLS suggestions. 123
'static' modifier out of order with the JLS suggestions. 128
variable 'log' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'. 128
cast needs to be followed by whitespace. 173
Expected an @return tag. 217
Expected @param tag for 'pluginName'. 217
',' needs to be followed by whitespace. 219
Expected an @return tag. 225
Expected @param tag for 'pluginName'. 225
Expected an @return tag. 238
Expected @param tag for 'f'. 238
Expected @throws tag for 'IOException'. 239
line longer than 80 characters 287
line longer than 80 characters 288
',' needs to be followed by whitespace. 288
line longer than 80 characters 305
line longer than 80 characters 319
',' needs to be followed by whitespace. 320
line longer than 80 characters 329
line longer than 80 characters 332
line longer than 80 characters 343
Expected @param tag for 'props'. 440
Expected @param tag for 'mavenHome'. 490
Expected @param tag for 'antProject'. 508
Expected @param tag for 'jellyContext'. 526
Expected @param tag for 'output'. 544
Expected @param tag for 'pluginsDir'. 562
Expected @param tag for 'projectVerifier'. 580
Expected an @return tag. 588

org/apache/maven/app/MavenJellyContext.java

Error Line
line longer than 80 characters 90
line longer than 80 characters 98
line longer than 80 characters 100
method is missing a Javadoc comment. 131
line longer than 80 characters 220
cast needs to be followed by whitespace. 220
Expected an @return tag. 234
Expected @param tag for 's'. 234

org/apache/maven/MavenUtils.java

Error Line
Unused import - java.io.FileOutputStream 62
Unused import - java.io.PipedInputStream 65
Unused import - java.io.PipedOutputStream 66
Unused import - java.util.HashMap 71
Unused import - java.util.Map 74
Unused import - org.apache.maven.project.Dependency 88
Duplicate import to line 60. 95
Unused import - java.io.FileWriter 96
Duplicate import to line 63. 97
Unused import - java.net.MalformedURLException 100
Unused import - java.net.URL 101
variable 'log' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'. 124
line longer than 80 characters 142
method is missing a Javadoc comment. 142
method is missing a Javadoc comment. 148
line longer than 80 characters 161
Expected @param tag for 'dir'. 161
Expected @param tag for 'parentContext'. 161
line longer than 80 characters 170
',' needs to be followed by whitespace. 170
line longer than 80 characters 186
Expected @param tag for 'project'. 186
Expected @param tag for 'parentContext'. 186
Expected @throws tag for 'Exception'. 187
line longer than 80 characters 210
'(' is followed by whitespace. 210
'(' is followed by whitespace. 210
')' is preceeded by whitespace. 210
line longer than 80 characters 219
Expected an @return tag. 226
Expected @throws tag for 'Exception'. 227
Expected @throws tag for 'Exception'. 244
method is missing a Javadoc comment. 255
Expected an @return tag. 267
Expected @param tag for 'child'. 267
Expected @param tag for 'parent'. 267
Expected @throws tag for 'Exception'. 268
Expected an @return tag. 277
Expected @param tag for 'child'. 277
Expected @param tag for 'parent'. 277
Expected an @return tag. 314
Expected @param tag for 'o'. 314
'if' construct must use '{}'s. 316
'if' construct must use '{}'s. 317
'if' construct must use '{}'s. 318
'if' construct must use '{}'s. 319
Expected an @return tag. 329
Expected @param tag for 'o'. 329
cast needs to be followed by whitespace. 331
Expected an @return tag. 484
Expected @param tag for 'directory'. 484
Expected @param tag for 'includes'. 484
Expected @throws tag for 'Exception'. 485
line longer than 80 characters 493
Unused @throws tag for 'IntrospectionException'. 504
Expected @throws tag for 'Exception'. 508

org/apache/maven/java/BaseVisitor.java

Error Line
method is missing a Javadoc comment. 217
method is missing a Javadoc comment. 252
method is missing a Javadoc comment. 277
method is missing a Javadoc comment. 282
method is missing a Javadoc comment. 297
method is missing a Javadoc comment. 302
method is missing a Javadoc comment. 307
method is missing a Javadoc comment. 332
method is missing a Javadoc comment. 337
method is missing a Javadoc comment. 342
method is missing a Javadoc comment. 357
method is missing a Javadoc comment. 362
method is missing a Javadoc comment. 367
method is missing a Javadoc comment. 372
method is missing a Javadoc comment. 377
method is missing a Javadoc comment. 382
method is missing a Javadoc comment. 387
method is missing a Javadoc comment. 392
method is missing a Javadoc comment. 397
method is missing a Javadoc comment. 402
method is missing a Javadoc comment. 407
method is missing a Javadoc comment. 412
method is missing a Javadoc comment. 417
method is missing a Javadoc comment. 423
method is missing a Javadoc comment. 429
method is missing a Javadoc comment. 435
method is missing a Javadoc comment. 441
method is missing a Javadoc comment. 447
method is missing a Javadoc comment. 453
method is missing a Javadoc comment. 459
method is missing a Javadoc comment. 465
method is missing a Javadoc comment. 471
method is missing a Javadoc comment. 477
method is missing a Javadoc comment. 483
method is missing a Javadoc comment. 489
method is missing a Javadoc comment. 495
method is missing a Javadoc comment. 501
method is missing a Javadoc comment. 507
method is missing a Javadoc comment. 513
method is missing a Javadoc comment. 519
method is missing a Javadoc comment. 525
method is missing a Javadoc comment. 531
method is missing a Javadoc comment. 537
method is missing a Javadoc comment. 543
method is missing a Javadoc comment. 549
method is missing a Javadoc comment. 555
method is missing a Javadoc comment. 561
method is missing a Javadoc comment. 567
method is missing a Javadoc comment. 573
method is missing a Javadoc comment. 579
method is missing a Javadoc comment. 585
method is missing a Javadoc comment. 591
method is missing a Javadoc comment. 597
method is missing a Javadoc comment. 603
method is missing a Javadoc comment. 609
method is missing a Javadoc comment. 615
method is missing a Javadoc comment. 620
method is missing a Javadoc comment. 625
method is missing a Javadoc comment. 630
method is missing a Javadoc comment. 635
method is missing a Javadoc comment. 640
method is missing a Javadoc comment. 645
method is missing a Javadoc comment. 650
method is missing a Javadoc comment. 655
method is missing a Javadoc comment. 660
method is missing a Javadoc comment. 665
method is missing a Javadoc comment. 670
method is missing a Javadoc comment. 675
method is missing a Javadoc comment. 680
method is missing a Javadoc comment. 685
method is missing a Javadoc comment. 690
method is missing a Javadoc comment. 695
method is missing a Javadoc comment. 700

org/apache/maven/java/DepVisitor.java

Error Line
type is missing a Javadoc comment. 67
variable 'packageStatements' must be private and have accessor methods. 74
variable 'importStatements' must be private and have accessor methods. 80
variable 'methods' missing Javadoc. 82
variable 'methods' must be private and have accessor methods. 82
method is missing a Javadoc comment. 94
method is missing a Javadoc comment. 103
Expected an @return tag. 119

org/apache/maven/java/ImportStatementVisitor.java

Error Line
type is missing a Javadoc comment. 65
variable 'importStatements' must be private and have accessor methods. 72
method is missing a Javadoc comment. 82

org/apache/maven/java/JavaClass.java

Error Line
type Javadoc comment is missing an @author tag. 64

org/apache/maven/java/JavaDocTagTokenizer.java

Error Line
'static' modifier out of order with the JLS suggestions. 86
'static' modifier out of order with the JLS suggestions. 89
'static' modifier out of order with the JLS suggestions. 92
'static' modifier out of order with the JLS suggestions. 95

org/apache/maven/java/JavaDocVisitor.java

Error Line
type is missing a Javadoc comment. 62
method is missing a Javadoc comment. 81
method is missing a Javadoc comment. 155

org/apache/maven/java/Method.java

Error Line
type is missing a Javadoc comment. 59
variable 'returnType' missing Javadoc. 61
method is missing a Javadoc comment. 63
method is missing a Javadoc comment. 68

org/apache/maven/java/NodeViewVisitor.java

Error Line
Expected an @return tag. 99
Expected @param tag for 'node'. 99
Expected @param tag for 'data'. 99

org/apache/maven/java/SourceTool.java

Error Line
Expected @param tag for 'visitor'. 106

org/apache/maven/jelly/tags/project/AddPathTag.java

Error Line
variable 'id' missing Javadoc. 76
variable 'refid' missing Javadoc. 77
method is missing a Javadoc comment. 79
method is missing a Javadoc comment. 84
method is missing a Javadoc comment. 101
method is missing a Javadoc comment. 106
method is missing a Javadoc comment. 111
method is missing a Javadoc comment. 116

org/apache/maven/jelly/tags/project/DirectoryList.java

Error Line
variable 'directory' missing Javadoc. 80
Unused @param tag for 'projectDescriptor'. 84
Expected @param tag for 'directory'. 86

org/apache/maven/jelly/tags/project/SnapshotSignature.java

Error Line
method is missing a Javadoc comment. 101

org/apache/maven/jelly/tags/project/MavenTag.java

Error Line
type is missing a Javadoc comment. 69
variable 'descriptor' missing Javadoc. 72
variable 'basedir' missing Javadoc. 73
variable 'goals' missing Javadoc. 74
variable 'ignore' missing Javadoc. 76
method is missing a Javadoc comment. 78
method is missing a Javadoc comment. 129
method is missing a Javadoc comment. 134
method is missing a Javadoc comment. 139
method is missing a Javadoc comment. 144
method is missing a Javadoc comment. 149
method is missing a Javadoc comment. 154
method is missing a Javadoc comment. 159

org/apache/maven/MetaPropertiesRule.java

Error Line
Line does not match expected header line of ' * 3. The end-user documentation included with the redistribution,'. 21
variable 'value' missing Javadoc. 73

org/apache/maven/project/repository/CvsRepository.java

Error Line
variable 'method' missing Javadoc. 69
variable 'user' missing Javadoc. 70
variable 'password' missing Javadoc. 71
variable 'hostname' missing Javadoc. 72
variable 'path' missing Javadoc. 73
variable 'type' missing Javadoc. 74
Expected @param tag for 'method'. 79
Expected an @return tag. 87
Expected @param tag for 'user'. 95
Expected an @return tag. 103
Expected @param tag for 'password'. 111
Expected an @return tag. 119
Expected @param tag for 'hostname'. 127
Expected an @return tag. 135
Expected @param tag for 'path'. 143
Expected an @return tag. 151
Expected @param tag for 'type'. 159
Expected an @return tag. 167

org/apache/maven/project/BaseObject.java

Error Line
variable 'combinedProperties' missing Javadoc. 94
Expected an @return tag. 161
Expected @param tag for 'name'. 161
Expected @param tag for 'combinedProperties'. 175
Expected an @return tag. 183
Expected an @return tag. 192

org/apache/maven/project/Dependency.java

Error Line
Expected an @return tag. 110
Expected @param tag for 'projectId'. 156
Expected an @return tag. 164
Expected @param tag for 'artifact'. 172
Expected an @return tag. 198
Expected an @return tag. 213
Expected @param tag for 'type'. 305
Expected an @return tag. 314
Expected an @return tag. 328
Expected @param tag for 'isPoorlyNamed'. 338
Expected an @return tag. 346

org/apache/maven/project/Project.java

Error Line
Expected @param tag for 'pomToExtend'. 268
Expected an @return tag. 276
Expected @param tag for 'gumpRepositoryId'. 284
Expected an @return tag. 292
Expected @param tag for 'shortDescription'. 300
Expected an @return tag. 308
Expected an @return tag. 320
Expected @throws tag for 'Exception'. 321
Expected an @return tag. 333
Expected @throws tag for 'Exception'. 334
Expected @param tag for 'dependencies'. 439
Expected @param tag for 'id'. 455
Expected @param tag for 'path'. 455
Expected an @return tag. 463
Expected @param tag for 'id'. 463
Expected an @return tag. 471
Expected @param tag for 'id'. 471
Expected @param tag for 'mailingLists'. 507
method is missing a Javadoc comment. 532
Expected @param tag for 'contributors'. 550
Expected @param tag for 'versions'. 818

org/apache/maven/project/Repository.java

Error Line
variable 'connection' missing Javadoc. 69
variable 'url' missing Javadoc. 70
Expected @param tag for 'connection'. 75
Expected an @return tag. 83
Expected @param tag for 'url'. 91
Expected an @return tag. 99
method is missing a Javadoc comment. 104
line longer than 80 characters 106
method is missing a Javadoc comment. 109

org/apache/maven/project/UnitTest.java

Error Line
variable 'resources' missing Javadoc. 69
variable 'includes' missing Javadoc. 70
variable 'excludes' missing Javadoc. 71
method is missing a Javadoc comment. 73
Expected @param tag for 'resources'. 83
line longer than 80 characters 90

org/apache/maven/project/Workspace.java

Error Line
Expected @param tag for 'workspaceVersion'. 94
Expected an @return tag. 102
Expected @param tag for 'baseDirectory'. 110
Expected an @return tag. 118
Expected @param tag for 'distributionDirectory'. 126
Expected an @return tag. 134
Expected @param tag for 'javaHome'. 142
Expected an @return tag. 150
Expected @param tag for 'descriptorDirectory'. 158
Expected an @return tag. 166
Expected @param tag for 'profile'. 174
Expected an @return tag. 182

org/apache/maven/project/Build.java

Error Line
Expected @param tag for 'sourceModification'. 208
Expected @param tag for 'sourceModifications'. 214
Expected an @return tag. 220
Expected @param tag for 'unitTest'. 355
method is missing a Javadoc comment. 370
method is missing a Javadoc comment. 375

org/apache/maven/project/SourceModification.java

Error Line
Expected @param tag for 'className'. 87
Expected an @return tag. 95
Expected @param tag for 'property'. 103
Expected an @return tag. 111

org/apache/maven/repository/AbstractArtifact.java

Error Line
method is missing a Javadoc comment. 66
method is missing a Javadoc comment. 67

org/apache/maven/repository/AbstractRepositoryLayout.java

Error Line
line longer than 80 characters 62

org/apache/maven/repository/Artifact.java

Error Line
method is missing a Javadoc comment. 66
method is missing a Javadoc comment. 67

org/apache/maven/repository/DefaultJarArtifact.java

Error Line
variable 'log' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'. 77
'static' modifier out of order with the JLS suggestions. 83
variable 'ps' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'. 83
Expected @param tag for 'dependency'. 93
Expected an @return tag. 101
Expected an @return tag. 110
Expected an @return tag. 123
Expected an @return tag. 136

org/apache/maven/repository/DefaultRepositoryLayout.java

Error Line
line longer than 80 characters 62

org/apache/maven/util/HttpUtils.java

Error Line
line longer than 80 characters 92
line longer than 80 characters 108
line longer than 80 characters 139
method length is 164 lines (max allowed is 150). 140
line longer than 80 characters 321

org/apache/maven/util/StringInputStream.java

Error Line
Line does not match expected header line of ' * "Apache Maven" must not be used to endorse or promote products'. 29

org/apache/maven/CreateDependencyClasspath.java

Error Line
line longer than 80 characters 76
variable 'mavenProject' missing Javadoc. 90
'static' modifier out of order with the JLS suggestions. 95
variable 'ps' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'. 95
Expected @param tag for 'context'. 104
Expected an @return tag. 112
Expected @param tag for 'refid'. 120
Expected an @return tag. 128
Expected @param tag for 'mavenProject'. 136
Expected an @return tag. 144
Expected @throws tag for 'Exception'. 158
line longer than 80 characters 167
line longer than 80 characters 168
line longer than 80 characters 169
line longer than 80 characters 172